Skip to content

Commit

Permalink
utf8.c: remove print_wrapped_text()
Browse files Browse the repository at this point in the history
strbuf_add_wrapped_text() is called only from print_wrapped_text()
without a strbuf (in which case it writes its results to stdout).

At its only callsite, supply a strbuf, call strbuf_add_wrapped_text()
directly and remove the wrapper function.

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
René Scharfe authored and Junio C Hamano committed Feb 20, 2010
1 parent 8a3c63e commit bb96a2c
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 9 deletions.
17 changes: 14 additions & 3 deletions builtin-shortlog.c
Original file line number Diff line number Diff line change
Expand Up @@ -301,9 +301,19 @@ int cmd_shortlog(int argc, const char **argv, const char *prefix)
return 0;
}

static void add_wrapped_shortlog_msg(struct strbuf *sb, const char *s,
const struct shortlog *log)
{
int col = strbuf_add_wrapped_text(sb, s, log->in1, log->in2, log->wrap);
if (col != log->wrap)
strbuf_addch(sb, '\n');
}

void shortlog_output(struct shortlog *log)
{
int i, j;
struct strbuf sb = STRBUF_INIT;

if (log->sort_by_number)
qsort(log->list.items, log->list.nr, sizeof(struct string_list_item),
compare_by_number);
Expand All @@ -318,9 +328,9 @@ void shortlog_output(struct shortlog *log)
const char *msg = onelines->items[j].string;

if (log->wrap_lines) {
int col = print_wrapped_text(msg, log->in1, log->in2, log->wrap);
if (col != log->wrap)
putchar('\n');
strbuf_reset(&sb);
add_wrapped_shortlog_msg(&sb, msg, log);
fwrite(sb.buf, sb.len, 1, stdout);
}
else
printf(" %s\n", msg);
Expand All @@ -334,6 +344,7 @@ void shortlog_output(struct shortlog *log)
log->list.items[i].util = NULL;
}

strbuf_release(&sb);
log->list.strdup_strings = 1;
string_list_clear(&log->list, 1);
clear_mailmap(&log->mailmap);
Expand Down
5 changes: 0 additions & 5 deletions utf8.c
Original file line number Diff line number Diff line change
Expand Up @@ -405,11 +405,6 @@ int strbuf_add_wrapped_text(struct strbuf *buf,
}
}

int print_wrapped_text(const char *text, int indent, int indent2, int width)
{
return strbuf_add_wrapped_text(NULL, text, indent, indent2, width);
}

int is_encoding_utf8(const char *name)
{
if (!name)
Expand Down
1 change: 0 additions & 1 deletion utf8.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ int utf8_strwidth(const char *string);
int is_utf8(const char *text);
int is_encoding_utf8(const char *name);

int print_wrapped_text(const char *text, int indent, int indent2, int len);
int strbuf_add_wrapped_text(struct strbuf *buf,
const char *text, int indent, int indent2, int width);

Expand Down

0 comments on commit bb96a2c

Please sign in to comment.