Skip to content

Commit

Permalink
cvsimport: allow for multiple -M options
Browse files Browse the repository at this point in the history
Use Getopt::Long instead of Getopt::Std to handle multiple -M options,
for all the cases when having a single custom regex is not enough.

Signed-off-by: Philippe Bruhat (BooK) <book@cpan.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Philippe Bruhat (BooK authored and Junio C Hamano committed Mar 1, 2008
1 parent fbbbc36 commit bc434e8
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions git-cvsimport.perl
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

use strict;
use warnings;
use Getopt::Std;
use Getopt::Long;
use File::Spec;
use File::Temp qw(tempfile tmpnam);
use File::Path qw(mkpath);
Expand All @@ -29,7 +29,7 @@
$SIG{'PIPE'}="IGNORE";
$ENV{'TZ'}="UTC";

our ($opt_h,$opt_o,$opt_v,$opt_k,$opt_u,$opt_d,$opt_p,$opt_C,$opt_z,$opt_i,$opt_P, $opt_s,$opt_m,$opt_M,$opt_A,$opt_S,$opt_L, $opt_a, $opt_r);
our ($opt_h,$opt_o,$opt_v,$opt_k,$opt_u,$opt_d,$opt_p,$opt_C,$opt_z,$opt_i,$opt_P, $opt_s,$opt_m,@opt_M,$opt_A,$opt_S,$opt_L, $opt_a, $opt_r);
my (%conv_author_name, %conv_author_email);

sub usage(;$) {
Expand Down Expand Up @@ -112,7 +112,12 @@ sub read_repo_config {

my $opts = "haivmkuo:d:p:r:C:z:s:M:P:A:S:L:";
read_repo_config($opts);
getopts($opts) or usage();
Getopt::Long::Configure( 'no_ignore_case', 'bundling' );

# turn the Getopt::Std specification in a Getopt::Long one,
# with support for multiple -M options
GetOptions( map { s/:/=s/; /M/ ? "$_\@" : $_ } split( /(?!:)/, $opts ) )
or usage();
usage if $opt_h;

if (@ARGV == 0) {
Expand Down Expand Up @@ -166,8 +171,8 @@ sub read_repo_config {
if ($opt_m) {
@mergerx = ( qr/\b(?:from|of|merge|merging|merged) ([-\w]+)/i );
}
if ($opt_M) {
push (@mergerx, qr/$opt_M/);
if (@opt_M) {
push (@mergerx, map { qr/$_/ } @opt_M);
}

# Remember UTC of our starting time
Expand Down

0 comments on commit bc434e8

Please sign in to comment.