Skip to content

Commit

Permalink
git-svnimport: Use separate arguments in the pipe for git-rev-parse
Browse files Browse the repository at this point in the history
Some people seem to create SVN branch names with spaces
or other shell metacharacters.

Signed-off-by: Matthias Urlichs <smurf@smurf.noris.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Matthias Urlichs authored and Junio C Hamano committed Sep 18, 2007
1 parent 7a461b5 commit bf1ee63
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion git-svnimport.perl
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,7 @@ sub commit {

my $rev;
if($revision > $opt_s and defined $parent) {
open(H,"git-rev-parse --verify $parent |");
open(H,'-|',"git-rev-parse","--verify",$parent);
$rev = <H>;
close(H) or do {
print STDERR "$revision: cannot find commit '$parent'!\n";
Expand Down

0 comments on commit bf1ee63

Please sign in to comment.