Skip to content

Commit

Permalink
test-lib.sh: Add check for invalid use of 'skip_all' facility
Browse files Browse the repository at this point in the history
The 'skip_all' facility cannot be used after one or more tests
have been executed using (for example) 'test_expect_success'.
To do so results in invalid TAP output, which leads to 'prove'
complaining of "Parse errors: No plan found in TAP output".

Add a check for such invalid usage and abort the test with an
error message to alert the test author.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Ramsay Jones authored and Junio C Hamano committed Sep 3, 2012
1 parent 1c0cc75 commit bf4b721
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions t/test-lib.sh
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,10 @@ test_done () {
case "$test_failure" in
0)
# Maybe print SKIP message
if test -n "$skip_all" && test $test_count -gt 0
then
error "Can't use skip_all after running some tests"
fi
[ -z "$skip_all" ] || skip_all=" # SKIP $skip_all"

if test $test_external_has_tap -eq 0
Expand Down

0 comments on commit bf4b721

Please sign in to comment.