Skip to content

Commit

Permalink
Correct some sizeof(size_t) != sizeof(unsigned long) typing errors
Browse files Browse the repository at this point in the history
Fix size_t vs. unsigned long pointer mismatch warnings introduced
with the addition of strbuf_detach().

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
  • Loading branch information
René Scharfe authored and Shawn O. Pearce committed Oct 22, 2007
1 parent 5be507f commit c32f749
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 5 deletions.
2 changes: 1 addition & 1 deletion builtin-apply.c
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ struct patch {
unsigned int is_rename:1;
struct fragment *fragments;
char *result;
unsigned long resultsize;
size_t resultsize;
char old_sha1_prefix[41];
char new_sha1_prefix[41];
struct patch *next;
Expand Down
4 changes: 3 additions & 1 deletion builtin-archive.c
Original file line number Diff line number Diff line change
Expand Up @@ -148,12 +148,14 @@ void *sha1_file_to_archive(const char *path, const unsigned char *sha1,
buffer = read_sha1_file(sha1, type, sizep);
if (buffer && S_ISREG(mode)) {
struct strbuf buf;
size_t size = 0;

strbuf_init(&buf, 0);
strbuf_attach(&buf, buffer, *sizep, *sizep + 1);
convert_to_working_tree(path, buf.buf, buf.len, &buf);
convert_to_archive(path, buf.buf, buf.len, &buf, commit);
buffer = strbuf_detach(&buf, sizep);
buffer = strbuf_detach(&buf, &size);
*sizep = size;
}

return buffer;
Expand Down
8 changes: 6 additions & 2 deletions diff.c
Original file line number Diff line number Diff line change
Expand Up @@ -1512,14 +1512,16 @@ static int reuse_worktree_file(const char *name, const unsigned char *sha1, int
static int populate_from_stdin(struct diff_filespec *s)
{
struct strbuf buf;
size_t size = 0;

strbuf_init(&buf, 0);
if (strbuf_read(&buf, 0, 0) < 0)
return error("error while reading from stdin %s",
strerror(errno));

s->should_munmap = 0;
s->data = strbuf_detach(&buf, &s->size);
s->data = strbuf_detach(&buf, &size);
s->size = size;
s->should_free = 1;
return 0;
}
Expand Down Expand Up @@ -1609,9 +1611,11 @@ int diff_populate_filespec(struct diff_filespec *s, int size_only)
*/
strbuf_init(&buf, 0);
if (convert_to_git(s->path, s->data, s->size, &buf)) {
size_t size = 0;
munmap(s->data, s->size);
s->should_munmap = 0;
s->data = strbuf_detach(&buf, &s->size);
s->data = strbuf_detach(&buf, &size);
s->size = size;
s->should_free = 1;
}
}
Expand Down
4 changes: 3 additions & 1 deletion entry.c
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,10 @@ static int write_entry(struct cache_entry *ce, char *path, const struct checkout
*/
strbuf_init(&buf, 0);
if (convert_to_working_tree(ce->name, new, size, &buf)) {
size_t newsize = 0;
free(new);
new = strbuf_detach(&buf, &size);
new = strbuf_detach(&buf, &newsize);
size = newsize;
}

if (to_tempfile) {
Expand Down

0 comments on commit c32f749

Please sign in to comment.