Skip to content

Commit

Permalink
send-email: die if CA path doesn't exist
Browse files Browse the repository at this point in the history
If the CA path isn't found it's most likely to indicate a
misconfiguration, in which case accepting any certificate is unlikely to
be the correct thing to do.

Signed-off-by: John Keeping <john@keeping.me.uk>
Signed-off-by: Jeff King <peff@peff.net>
  • Loading branch information
John Keeping authored and Jeff King committed Nov 24, 2015
1 parent 0c83680 commit c55d65f
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions git-send-email.perl
Original file line number Diff line number Diff line change
Expand Up @@ -1196,8 +1196,7 @@ sub ssl_verify_params {
return (SSL_verify_mode => SSL_VERIFY_PEER(),
SSL_ca_file => $smtp_ssl_cert_path);
} else {
print STDERR "Not using SSL_VERIFY_PEER because the CA path does not exist.\n";
return (SSL_verify_mode => SSL_VERIFY_NONE());
die "CA path \"$smtp_ssl_cert_path\" does not exist";
}
}

Expand Down

0 comments on commit c55d65f

Please sign in to comment.