Skip to content

Commit

Permalink
wt-status: lift the artificual "at least 20 columns" floor
Browse files Browse the repository at this point in the history
When we show unmerged paths, we had an artificial 20 columns floor
for the width of labels (e.g. "both deleted:") shown next to the
pathnames.  Depending on the locale, this may result in a label that
is too wide when all the label strings are way shorter than 20
columns, or no-op when a label string is longer than 20 columns.

Just drop the artificial floor.  The screen real estate is better
utilized this way when all the strings are shorter.

Adjust the tests to this change.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Junio C Hamano committed Mar 12, 2014
1 parent 8f17f5b commit c7cb333
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 15 deletions.
14 changes: 7 additions & 7 deletions t/t7060-wtstatus.sh
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ You have unmerged paths.
Unmerged paths:
(use "git add/rm <file>..." as appropriate to mark resolution)
deleted by us: foo
deleted by us: foo
no changes added to commit (use "git add" and/or "git commit -a")
EOF
Expand Down Expand Up @@ -142,8 +142,8 @@ You have unmerged paths.
Unmerged paths:
(use "git add/rm <file>..." as appropriate to mark resolution)
both added: conflict.txt
deleted by them: main.txt
both added: conflict.txt
deleted by them: main.txt
no changes added to commit (use "git add" and/or "git commit -a")
EOF
Expand Down Expand Up @@ -175,9 +175,9 @@ You have unmerged paths.
Unmerged paths:
(use "git add/rm <file>..." as appropriate to mark resolution)
both deleted: main.txt
added by them: sub_master.txt
added by us: sub_second.txt
both deleted: main.txt
added by them: sub_master.txt
added by us: sub_second.txt
no changes added to commit (use "git add" and/or "git commit -a")
EOF
Expand All @@ -203,7 +203,7 @@ Changes to be committed:
Unmerged paths:
(use "git rm <file>..." to mark resolution)
both deleted: main.txt
both deleted: main.txt
Untracked files not listed (use -u option to show untracked files)
EOF
Expand Down
12 changes: 6 additions & 6 deletions t/t7512-status-help.sh
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ You have unmerged paths.
Unmerged paths:
(use "git add <file>..." to mark resolution)
both modified: main.txt
both modified: main.txt
no changes added to commit (use "git add" and/or "git commit -a")
EOF
Expand Down Expand Up @@ -87,7 +87,7 @@ Unmerged paths:
(use "git reset HEAD <file>..." to unstage)
(use "git add <file>..." to mark resolution)
both modified: main.txt
both modified: main.txt
no changes added to commit (use "git add" and/or "git commit -a")
EOF
Expand Down Expand Up @@ -146,7 +146,7 @@ Unmerged paths:
(use "git reset HEAD <file>..." to unstage)
(use "git add <file>..." to mark resolution)
both modified: main.txt
both modified: main.txt
no changes added to commit (use "git add" and/or "git commit -a")
EOF
Expand Down Expand Up @@ -602,7 +602,7 @@ rebase in progress; onto $ONTO
You are currently rebasing branch '\''statushints_disabled'\'' on '\''$ONTO'\''.
Unmerged paths:
both modified: main.txt
both modified: main.txt
no changes added to commit
EOF
Expand Down Expand Up @@ -636,7 +636,7 @@ You are currently cherry-picking commit $TO_CHERRY_PICK.
Unmerged paths:
(use "git add <file>..." to mark resolution)
both modified: main.txt
both modified: main.txt
no changes added to commit (use "git add" and/or "git commit -a")
EOF
Expand Down Expand Up @@ -707,7 +707,7 @@ Unmerged paths:
(use "git reset HEAD <file>..." to unstage)
(use "git add <file>..." to mark resolution)
both modified: to-revert.txt
both modified: to-revert.txt
no changes added to commit (use "git add" and/or "git commit -a")
EOF
Expand Down
2 changes: 0 additions & 2 deletions wt-status.c
Original file line number Diff line number Diff line change
Expand Up @@ -318,8 +318,6 @@ static void wt_status_print_unmerged_data(struct wt_status *s,
if (!padding) {
label_width = maxwidth(wt_status_unmerged_status_string, 1, 7);
label_width += strlen(" ");
if (label_width < 20)
label_width = 20;
padding = xmallocz(label_width);
memset(padding, ' ', label_width);
}
Expand Down

0 comments on commit c7cb333

Please sign in to comment.