Skip to content

Commit

Permalink
log: when --cc is given, default to -p unless told otherwise
Browse files Browse the repository at this point in the history
The "--cc" option to "git log" is clearly a request to show some
sort of combined diff (be it --patch or --raw), but traditionally
we required the command line to explicitly ask for "git log -p --cc".

Teach the command line parser to treat a lone "--cc" as if the user
specified "-p --cc".  Formats that do ask for other forms of diff
output, e.g. "log --raw --cc", are not overriden.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Junio C Hamano committed Aug 20, 2015
1 parent b130c70 commit c7eaf8b
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions builtin/log.c
Original file line number Diff line number Diff line change
Expand Up @@ -633,6 +633,10 @@ static void log_setup_revisions_tweak(struct rev_info *rev,
if (DIFF_OPT_TST(&rev->diffopt, DEFAULT_FOLLOW_RENAMES) &&
rev->prune_data.nr == 1)
DIFF_OPT_SET(&rev->diffopt, FOLLOW_RENAMES);

/* Turn --cc/-c into -p --cc/-c when -p was not given */
if (!rev->diffopt.output_format && rev->combine_merges)
rev->diffopt.output_format = DIFF_FORMAT_PATCH;
}

int cmd_log(int argc, const char **argv, const char *prefix)
Expand Down

0 comments on commit c7eaf8b

Please sign in to comment.