Skip to content

Commit

Permalink
Revert "read_directory: show_both option."
Browse files Browse the repository at this point in the history
This reverts commit 4888c53.
  • Loading branch information
Junio C Hamano committed Dec 29, 2006
1 parent 8757749 commit c889763
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 16 deletions.
19 changes: 7 additions & 12 deletions dir.c
Original file line number Diff line number Diff line change
Expand Up @@ -260,8 +260,7 @@ int excluded(struct dir_struct *dir, const char *pathname)
return 0;
}

static void add_name(struct dir_struct *dir, const char *pathname, int len,
int ignored_entry)
static void add_name(struct dir_struct *dir, const char *pathname, int len)
{
struct dir_entry *ent;

Expand All @@ -274,7 +273,6 @@ static void add_name(struct dir_struct *dir, const char *pathname, int len,
dir->entries = xrealloc(dir->entries, alloc*sizeof(ent));
}
ent = xmalloc(sizeof(*ent) + len + 1);
ent->ignored_entry = ignored_entry;
ent->len = len;
memcpy(ent->name, pathname, len);
ent->name[len] = 0;
Expand Down Expand Up @@ -316,7 +314,6 @@ static int read_directory_recursive(struct dir_struct *dir, const char *path, co

while ((de = readdir(fdir)) != NULL) {
int len;
int ignored_entry;

if ((de->d_name[0] == '.') &&
(de->d_name[1] == 0 ||
Expand All @@ -325,12 +322,11 @@ static int read_directory_recursive(struct dir_struct *dir, const char *path, co
continue;
len = strlen(de->d_name);
memcpy(fullname + baselen, de->d_name, len+1);
ignored_entry = excluded(dir, fullname);

if (!dir->show_both &&
(ignored_entry != dir->show_ignored) &&
(!dir->show_ignored || DTYPE(de) != DT_DIR))
continue;
if (excluded(dir, fullname) != dir->show_ignored) {
if (!dir->show_ignored || DTYPE(de) != DT_DIR) {
continue;
}
}

switch (DTYPE(de)) {
struct stat st;
Expand Down Expand Up @@ -368,8 +364,7 @@ static int read_directory_recursive(struct dir_struct *dir, const char *path, co
if (check_only)
goto exit_early;
else
add_name(dir, fullname, baselen + len,
ignored_entry);
add_name(dir, fullname, baselen + len);
}
exit_early:
closedir(fdir);
Expand Down
6 changes: 2 additions & 4 deletions dir.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@


struct dir_entry {
unsigned ignored_entry : 1;
unsigned int len : 15;
int len;
char name[FLEX_ARRAY]; /* more */
};

Expand All @@ -30,8 +29,7 @@ struct exclude_list {

struct dir_struct {
int nr, alloc;
unsigned int show_both: 1,
show_ignored:1,
unsigned int show_ignored:1,
show_other_directories:1,
hide_empty_directories:1;
struct dir_entry **entries;
Expand Down

0 comments on commit c889763

Please sign in to comment.