Skip to content

Commit

Permalink
Fix "git-log --parents" breakage post v1.3.0
Browse files Browse the repository at this point in the history
Post 1.3.0 "git log" forgets to list parent commits on the first line
when --parents is given.  git-cvsserver relied on it.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Linus Torvalds authored and Junio C Hamano committed May 3, 2006
1 parent 060729d commit c8c893c
Showing 1 changed file with 16 additions and 2 deletions.
18 changes: 16 additions & 2 deletions log-tree.c
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,15 @@
#include "commit.h"
#include "log-tree.h"

static void show_parents(struct commit *commit, int abbrev)
{
struct commit_list *p;
for (p = commit->parents; p ; p = p->next) {
struct commit *parent = p->item;
printf(" %s", diff_unique_abbrev(parent->object.sha1, abbrev));
}
}

void show_log(struct rev_info *opt, struct log_info *log, const char *sep)
{
static char this_header[16384];
Expand All @@ -14,7 +23,10 @@ void show_log(struct rev_info *opt, struct log_info *log, const char *sep)

opt->loginfo = NULL;
if (!opt->verbose_header) {
puts(sha1_to_hex(commit->object.sha1));
fputs(diff_unique_abbrev(commit->object.sha1, abbrev_commit), stdout);
if (opt->parents)
show_parents(commit, abbrev_commit);
putchar('\n');
return;
}

Expand All @@ -40,7 +52,9 @@ void show_log(struct rev_info *opt, struct log_info *log, const char *sep)
printf("%s%s",
opt->commit_format == CMIT_FMT_ONELINE ? "" : "commit ",
diff_unique_abbrev(commit->object.sha1, abbrev_commit));
if (parent)
if (opt->parents)
show_parents(commit, abbrev_commit);
if (parent)
printf(" (from %s)", diff_unique_abbrev(parent->object.sha1, abbrev_commit));
putchar(opt->commit_format == CMIT_FMT_ONELINE ? ' ' : '\n');

Expand Down

0 comments on commit c8c893c

Please sign in to comment.