Skip to content

Commit

Permalink
mingw: remove mingw_write
Browse files Browse the repository at this point in the history
Since 0b6806b ("xread, xwrite: limit size of IO to 8MB"), this
wrapper is no longer needed, as read and write are already split
into small chunks.

Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Erik Faye-Lund authored and Junio C Hamano committed Jan 17, 2014
1 parent 7edc02f commit c9df6f4
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 20 deletions.
17 changes: 0 additions & 17 deletions compat/mingw.c
Original file line number Diff line number Diff line change
Expand Up @@ -304,23 +304,6 @@ int mingw_open (const char *filename, int oflags, ...)
return fd;
}

#undef write
ssize_t mingw_write(int fd, const void *buf, size_t count)
{
/*
* While write() calls to a file on a local disk are translated
* into WriteFile() calls with a maximum size of 64KB on Windows
* XP and 256KB on Vista, no such cap is placed on writes to
* files over the network on Windows XP. Unfortunately, there
* seems to be a limit of 32MB-28KB on X64 and 64MB-32KB on x86;
* bigger writes fail on Windows XP.
* So we cap to a nice 31MB here to avoid write failures over
* the net without changing the number of WriteFile() calls in
* the local case.
*/
return write(fd, buf, min(count, 31 * 1024 * 1024));
}

static BOOL WINAPI ctrl_ignore(DWORD type)
{
return TRUE;
Expand Down
3 changes: 0 additions & 3 deletions compat/mingw.h
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,6 @@ int mingw_rmdir(const char *path);
int mingw_open (const char *filename, int oflags, ...);
#define open mingw_open

ssize_t mingw_write(int fd, const void *buf, size_t count);
#define write mingw_write

int mingw_fgetc(FILE *stream);
#define fgetc mingw_fgetc

Expand Down

0 comments on commit c9df6f4

Please sign in to comment.