Skip to content

Commit

Permalink
Merge branch 'sb/traverse-trees-bitmask-variable-name'
Browse files Browse the repository at this point in the history
* sb/traverse-trees-bitmask-variable-name:
  traverse_trees(): clarify return value of the callback
  • Loading branch information
Junio C Hamano committed Jul 25, 2013
2 parents 356df9b + a04f819 commit cb18246
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions tree-walk.c
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,6 @@ static inline int prune_traversal(struct name_entry *e,

int traverse_trees(int n, struct tree_desc *t, struct traverse_info *info)
{
int ret = 0;
int error = 0;
struct name_entry *entry = xmalloc(n*sizeof(*entry));
int i;
Expand All @@ -341,6 +340,7 @@ int traverse_trees(int n, struct tree_desc *t, struct traverse_info *info)
strbuf_setlen(&base, info->pathlen);
}
for (;;) {
int trees_used;
unsigned long mask, dirmask;
const char *first = NULL;
int first_len = 0;
Expand Down Expand Up @@ -404,15 +404,14 @@ int traverse_trees(int n, struct tree_desc *t, struct traverse_info *info)
if (interesting < 0)
break;
if (interesting) {
ret = info->fn(n, mask, dirmask, entry, info);
if (ret < 0) {
error = ret;
trees_used = info->fn(n, mask, dirmask, entry, info);
if (trees_used < 0) {
error = trees_used;
if (!info->show_all_errors)
break;
}
mask &= ret;
mask &= trees_used;
}
ret = 0;
for (i = 0; i < n; i++)
if (mask & (1ul << i))
update_extended_entry(tx + i, entry + i);
Expand Down

0 comments on commit cb18246

Please sign in to comment.