Skip to content

Commit

Permalink
test-lib.sh: do not "echo" caller-supplied strings
Browse files Browse the repository at this point in the history
In some places we "echo" a string that is supplied by the calling
test script and may contain backslash sequences. The echo command
of some shells, most notably "dash", interprets these backslash
sequences (POSIX.1 allows this) which may scramble the test
output.

Signed-off-by: Uwe Storbeck <uwe@ibr.ch>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Uwe Storbeck authored and Junio C Hamano committed Mar 18, 2014
1 parent 47be066 commit cb1aefd
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions t/test-lib.sh
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ error "Test script did not set test_description."

if test "$help" = "t"
then
echo "$test_description"
printf '%s\n' "$test_description"
exit 0
fi

Expand Down Expand Up @@ -328,7 +328,7 @@ test_failure_ () {
test_failure=$(($test_failure + 1))
say_color error "not ok $test_count - $1"
shift
echo "$@" | sed -e 's/^/# /'
printf '%s\n' "$*" | sed -e 's/^/# /'
test "$immediate" = "" || { GIT_EXIT_OK=t; exit 1; }
}

Expand Down

0 comments on commit cb1aefd

Please sign in to comment.