Skip to content

Commit

Permalink
vcs-svn: allow input from file descriptor
Browse files Browse the repository at this point in the history
Based-on-patch-by: David Barr <david.barr@cordelta.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
  • Loading branch information
Jonathan Nieder committed Feb 26, 2011
1 parent cc193f1 commit cb3f87c
Show file tree
Hide file tree
Showing 5 changed files with 31 additions and 7 deletions.
9 changes: 9 additions & 0 deletions t/t0081-line-buffer.sh
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,15 @@ test_expect_success PIPE,EXPENSIVE 'longer read (around 65536 bytes)' '
long_read_test 65536
'

test_expect_success 'read from file descriptor' '
rm -f input &&
echo hello >expect &&
echo hello >input &&
echo copy 6 |
test-line-buffer "&4" 4<input >actual &&
test_cmp expect actual
'

test_expect_success 'buffer_read_string copes with null byte' '
>expect &&
q_to_nul <<-\EOF | test-line-buffer >actual &&
Expand Down
11 changes: 8 additions & 3 deletions test-line-buffer.c
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,18 @@ int main(int argc, char *argv[])
else if (argc == 2)
filename = argv[1];
else
usage("test-line-buffer [file] < script");
usage("test-line-buffer [file | &fd] < script");

if (buffer_init(&stdin_buf, NULL))
die_errno("open error");
if (filename) {
if (buffer_init(&file_buf, filename))
die_errno("error opening %s", filename);
if (*filename == '&') {
if (buffer_fdinit(&file_buf, strtouint32(filename + 1)))
die_errno("error opening fd %s", filename + 1);
} else {
if (buffer_init(&file_buf, filename))
die_errno("error opening %s", filename);
}
input = &file_buf;
}

Expand Down
8 changes: 8 additions & 0 deletions vcs-svn/line_buffer.c
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,14 @@ int buffer_init(struct line_buffer *buf, const char *filename)
return 0;
}

int buffer_fdinit(struct line_buffer *buf, int fd)
{
buf->infile = fdopen(fd, "r");
if (!buf->infile)
return -1;
return 0;
}

int buffer_deinit(struct line_buffer *buf)
{
int err;
Expand Down
1 change: 1 addition & 0 deletions vcs-svn/line_buffer.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ struct line_buffer {
#define LINE_BUFFER_INIT {"", STRBUF_INIT, NULL}

int buffer_init(struct line_buffer *buf, const char *filename);
int buffer_fdinit(struct line_buffer *buf, int fd);
int buffer_deinit(struct line_buffer *buf);
char *buffer_read_line(struct line_buffer *buf);
char *buffer_read_string(struct line_buffer *buf, uint32_t len);
Expand Down
9 changes: 5 additions & 4 deletions vcs-svn/line_buffer.txt
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,11 @@ resources.
Functions
---------

`buffer_init`::
Open the named file for input. If filename is NULL,
start reading from stdin. On failure, returns -1 (with
errno indicating the nature of the failure).
`buffer_init`, `buffer_fdinit`::
Open the named file or file descriptor for input.
buffer_init(buf, NULL) prepares to read from stdin.
On failure, returns -1 (with errno indicating the nature
of the failure).

`buffer_deinit`::
Stop reading from the current file (closing it unless
Expand Down

0 comments on commit cb3f87c

Please sign in to comment.