Skip to content

Commit

Permalink
i18n: git-revert split up "could not revert/apply" message
Browse files Browse the repository at this point in the history
Split up the "could not %s %s... %s" message into "could not revert
%s... %s" and "could not apply %s... %s". This makes it easier for
translators to understand the message.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Ævar Arnfjörð Bjarmason authored and Junio C Hamano committed Mar 10, 2011
1 parent b9c993e commit cb6aeb2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions builtin/revert.c
Original file line number Diff line number Diff line change
Expand Up @@ -536,8 +536,9 @@ static int do_pick_commit(void)
}

if (res) {
error("could not %s %s... %s",
action == REVERT ? "revert" : "apply",
error(action == REVERT
? _("could not revert %s... %s")
: _("could not apply %s... %s"),
find_unique_abbrev(commit->object.sha1, DEFAULT_ABBREV),
msg.subject);
print_advice();
Expand Down
2 changes: 1 addition & 1 deletion t/t3507-cherry-pick-conflict.sh
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ test_expect_success 'failed cherry-pick does not advance HEAD' '
test "$head" = "$newhead"
'

test_expect_success 'advice from failed cherry-pick' "
test_expect_success C_LOCALE_OUTPUT 'advice from failed cherry-pick' "
git checkout -f initial^0 &&
git read-tree -u --reset HEAD &&
git clean -d -f -f -q -x &&
Expand Down

0 comments on commit cb6aeb2

Please sign in to comment.