Skip to content

Commit

Permalink
Use local structs for HTTP slot callback data
Browse files Browse the repository at this point in the history
There's no need for these structures to be static, and it could potentially
cause problems down the road.

Signed-off-by: Nick Hengeveld <nickh@reactrix.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Nick Hengeveld authored and Junio C Hamano committed Feb 1, 2006
1 parent 8233340 commit cb754fd
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions http-fetch.c
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ static int fetch_index(struct alt_base *repo, unsigned char *sha1)

FILE *indexfile;
struct active_request_slot *slot;
static struct slot_results results;
struct slot_results results;

if (has_pack_index(sha1))
return 0;
Expand Down Expand Up @@ -555,7 +555,7 @@ static void fetch_alternates(char *base)
char *url;
char *data;
struct active_request_slot *slot;
static struct alternates_request alt_req;
struct alternates_request alt_req;

/* If another request has already started fetching alternates,
wait for them to arrive and return to processing this request's
Expand Down Expand Up @@ -618,7 +618,7 @@ static int fetch_indices(struct alt_base *repo)
int i = 0;

struct active_request_slot *slot;
static struct slot_results results;
struct slot_results results;

if (repo->got_indices)
return 0;
Expand Down Expand Up @@ -699,7 +699,7 @@ static int fetch_pack(struct alt_base *repo, unsigned char *sha1)
struct curl_slist *range_header = NULL;

struct active_request_slot *slot;
static struct slot_results results;
struct slot_results results;

if (fetch_indices(repo))
return -1;
Expand Down Expand Up @@ -900,7 +900,7 @@ int fetch_ref(char *ref, unsigned char *sha1)
struct buffer buffer;
char *base = alt->base;
struct active_request_slot *slot;
static struct slot_results results;
struct slot_results results;
buffer.size = 41;
buffer.posn = 0;
buffer.buffer = hex;
Expand Down

0 comments on commit cb754fd

Please sign in to comment.