Skip to content

Commit

Permalink
gitweb: Re-enable rev-list --parents for parse_commit.
Browse files Browse the repository at this point in the history
Re-enable rev-list --parents for parse_commit which was removed in
(208b2df).  rev-list --parents is not
just used to return the parent headers in the commit object, it
includes any grafts which are vaild for the commit.

Signed-off-by: Robert Fitzsimons <robfitz@273k.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Robert Fitzsimons authored and Junio C Hamano committed Dec 27, 2006
1 parent 2ef5805 commit ccdfdea
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions gitweb/gitweb.perl
Original file line number Diff line number Diff line change
Expand Up @@ -1271,7 +1271,7 @@ sub parse_tag {
}

sub parse_commit_text {
my ($commit_text) = @_;
my ($commit_text, $withparents) = @_;
my @commit_lines = split '\n', $commit_text;
my %co;

Expand All @@ -1281,13 +1281,12 @@ sub parse_commit_text {
if (!($header =~ m/^[0-9a-fA-F]{40}/)) {
return;
}
$co{'id'} = $header;
my @parents;
($co{'id'}, my @parents) = split ' ', $header;
while (my $line = shift @commit_lines) {
last if $line eq "\n";
if ($line =~ m/^tree ([0-9a-fA-F]{40})$/) {
$co{'tree'} = $1;
} elsif ($line =~ m/^parent ([0-9a-fA-F]{40})$/) {
} elsif ((!defined $withparents) && ($line =~ m/^parent ([0-9a-fA-F]{40})$/)) {
push @parents, $1;
} elsif ($line =~ m/^author (.*) ([0-9]+) (.*)$/) {
$co{'author'} = $1;
Expand Down Expand Up @@ -1373,12 +1372,13 @@ sub parse_commit {
local $/ = "\0";

open my $fd, "-|", git_cmd(), "rev-list",
"--parents",
"--header",
"--max-count=1",
$commit_id,
"--",
or die_error(undef, "Open git-rev-list failed");
%co = parse_commit_text(<$fd>);
%co = parse_commit_text(<$fd>, 1);
close $fd;

return %co;
Expand Down

0 comments on commit ccdfdea

Please sign in to comment.