Skip to content

Commit

Permalink
bisect: fix another instance of eval'ed string
Browse files Browse the repository at this point in the history
When there is nothing to be skipped, the output from
rev-list --bisect-vars was eval'ed without first being
strung together with &&; this is probably not a problem
as it is much less likely to be a bad input than the list
handcrafted by the filter_skip function, but it still is
a good discipline.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Christian Couder authored and Junio C Hamano committed Feb 27, 2009
1 parent 1b249ff commit cce074a
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion git-bisect.sh
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,13 @@ filter_skipped() {
_skip="$2"

if [ -z "$_skip" ]; then
eval_rev_list "$_eval"
eval_rev_list "$_eval" | {
while read line
do
echo "$line &&"
done
echo ':'
}
return
fi

Expand Down

0 comments on commit cce074a

Please sign in to comment.