Skip to content

Commit

Permalink
completion: trivial test improvement
Browse files Browse the repository at this point in the history
Instead of passing a dummy "", let's check if the last character is a
space, and then move the _cword accordingly.

Apparently we were passing "" all the way to compgen, which fortunately
expanded it to nothing.

Lets do the right thing though.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Felipe Contreras authored and Junio C Hamano committed Apr 12, 2013
1 parent 7655fa7 commit cdbff7d
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion t/t9902-completion.sh
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ run_completion ()
local -a COMPREPLY _words
local _cword
_words=( $1 )
test "${1: -1}" == ' ' && _words+=('')
(( _cword = ${#_words[@]} - 1 ))
__git_wrap__git_main && print_comp
}
Expand Down Expand Up @@ -148,7 +149,7 @@ test_expect_success '__gitcomp - suffix' '
'

test_expect_success 'basic' '
run_completion "git \"\"" &&
run_completion "git " &&
# built-in
grep -q "^add \$" out &&
# script
Expand Down

0 comments on commit cdbff7d

Please sign in to comment.