Skip to content

Commit

Permalink
t7502-commit: add summary output tests for empty and merge commits
Browse files Browse the repository at this point in the history
After c197702 (pretty: Respect --abbrev option), non-abbreviated hashes
began to appear, leading to failures for these tests.

Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Tay Ray Chuan authored and Junio C Hamano committed May 28, 2010
1 parent fc6fa0d commit cee9f2b
Showing 1 changed file with 27 additions and 2 deletions.
29 changes: 27 additions & 2 deletions t/t7502-commit.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ test_description='git commit porcelain-ish'

. ./test-lib.sh

# Arguments: [<prefix] [<commit message>]
# Arguments: [<prefix] [<commit message>] [<commit options>]
check_summary_oneline() {
test_tick &&
git commit -m "$2" | head -1 > act &&
git commit ${3+"$3"} -m "$2" | head -1 > act &&

# branch name
SUMMARY_PREFIX="$(git name-rev --name-only HEAD)" &&
Expand Down Expand Up @@ -36,6 +36,31 @@ test_expect_success 'output summary format' '
check_summary_oneline "" "a change"
'

test_expect_failure 'output summary format for commit with an empty diff' '
check_summary_oneline "" "empty" "--allow-empty"
'

test_expect_failure 'output summary format for merges' '
git checkout -b recursive-base &&
test_commit base file1 &&
git checkout -b recursive-a recursive-base &&
test_commit commit-a file1 &&
git checkout -b recursive-b recursive-base &&
test_commit commit-b file1 &&
# conflict
git checkout recursive-a &&
test_must_fail git merge recursive-b &&
# resolve the conflict
echo commit-a > file1 &&
git add file1 &&
check_summary_oneline "" "Merge"
'

output_tests_cleanup() {
# this is needed for "do not fire editor in the presence of conflicts"
git checkout master &&
Expand Down

0 comments on commit cee9f2b

Please sign in to comment.