Skip to content

Commit

Permalink
t1301: set umask in reflog sharedrepository=group test
Browse files Browse the repository at this point in the history
The t1301 script sets the umask globally before many of the
tests. Most of the tests that care about the umask then set
it explicitly at the start of the test. However, one test
does not, and relies on the 077 umask setting from earlier
tests. This is fragile and can break if another test is
added in between. Let's be more explicit.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Jeff King authored and Junio C Hamano committed Jan 6, 2015
1 parent 4489a48 commit d05c77c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions t/t1301-shared-repo.sh
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ do
done

test_expect_success POSIXPERM 'git reflog expire honors core.sharedRepository' '
umask 077 &&
git config core.sharedRepository group &&
git reflog expire --all &&
actual="$(ls -l .git/logs/refs/heads/master)" &&
Expand Down

0 comments on commit d05c77c

Please sign in to comment.