Skip to content

Commit

Permalink
t/t5000-tar-tree.sh: avoid "test <cond> -a/-o <cond>"
Browse files Browse the repository at this point in the history
The construct is error-prone; "test" being built-in in most modern
shells, the reason to avoid "test <cond> && test <cond>" spawning
one extra process by using a single "test <cond> -a <cond>" no
longer exists.

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Elia Pinto authored and Junio C Hamano committed Jun 9, 2014
1 parent 4399345 commit d0b30a3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion t/t5000-tar-tree.sh
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ check_tar() {
for header in *.paxheader
do
data=${header%.paxheader}.data &&
if test -h $data -o -e $data
if test -h $data || test -e $data
then
path=$(get_pax_header $header path) &&
if test -n "$path"
Expand Down

0 comments on commit d0b30a3

Please sign in to comment.