Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
git-stash.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.

The backquoted form is the traditional method for command
substitution, and is supported by POSIX.  However, all but the
simplest uses become complicated quickly.  In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.

The patch was generated by:

for _f in $(find . -name "*.sh")
do
   sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done

and then carefully proof-read.

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Elia Pinto authored and Junio C Hamano committed Apr 23, 2014
1 parent 728fc79 commit d0ea45b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion git-stash.sh
Expand Up @@ -13,7 +13,7 @@ USAGE="list [<options>]

SUBDIRECTORY_OK=Yes
OPTIONS_SPEC=
START_DIR=`pwd`
START_DIR=$(pwd)
. git-sh-setup
. git-sh-i18n
require_work_tree
Expand Down

0 comments on commit d0ea45b

Please sign in to comment.