Skip to content

Commit

Permalink
cmd_push: set "atomic" bit directly
Browse files Browse the repository at this point in the history
This makes the code shorter and more obvious by removing an
unnecessary interim variable.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Jeff King authored and Junio C Hamano committed Feb 17, 2015
1 parent 06038cd commit d16c33b
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions builtin/push.c
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,6 @@ int cmd_push(int argc, const char **argv, const char *prefix)
int flags = 0;
int tags = 0;
int rc;
int atomic = 0;
const char *repo = NULL; /* default repository */
struct option options[] = {
OPT__VERBOSITY(&verbosity),
Expand Down Expand Up @@ -518,7 +517,7 @@ int cmd_push(int argc, const char **argv, const char *prefix)
OPT_BIT(0, "follow-tags", &flags, N_("push missing but relevant tags"),
TRANSPORT_PUSH_FOLLOW_TAGS),
OPT_BIT(0, "signed", &flags, N_("GPG sign the push"), TRANSPORT_PUSH_CERT),
OPT_BOOL(0, "atomic", &atomic, N_("request atomic transaction on remote side")),
OPT_BIT(0, "atomic", &flags, N_("request atomic transaction on remote side"), TRANSPORT_PUSH_ATOMIC),
OPT_END()
};

Expand All @@ -534,9 +533,6 @@ int cmd_push(int argc, const char **argv, const char *prefix)
if (tags)
add_refspec("refs/tags/*");

if (atomic)
flags |= TRANSPORT_PUSH_ATOMIC;

if (argc > 0) {
repo = argv[0];
set_refspecs(argv + 1, argc - 1, repo);
Expand Down

0 comments on commit d16c33b

Please sign in to comment.