Skip to content

Commit

Permalink
Add backslash to list of 'crud' characters in real name
Browse files Browse the repository at this point in the history
We remove crud characters at the beginning and end of real-names so that
when we see email addresses like

	From: "David S. Miller" <davem@davemloft.net>

we drop the quotes around the name when we parse that and split it up into
name and email.

However, the list of crud characters was basically just a random list of
common things that are found around names, and it didn't contain the
backslash character that some insane scripts seem to use when quoting
things. So now the kernel has a number of authors listed like

	Author: \"Rafael J. Wysocki\ <rjw@sisk.pl>

because the author name had started out as

	From: \"Rafael J. Wysocki\" <rjw@sisk.pl>

and the only "crud" character we noticed and removed was the final
double-quote at the end.

We should probably do better quote removal from names anyway, but this is
the minimal obvious patch.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Linus Torvalds authored and Junio C Hamano committed Dec 2, 2008
1 parent 46059cc commit d404bf0
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions ident.c
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ static int crud(unsigned char c)
c == '<' ||
c == '>' ||
c == '"' ||
c == '\\' ||
c == '\'';
}

Expand Down

0 comments on commit d404bf0

Please sign in to comment.