Skip to content

Commit

Permalink
tests: "cp -a" is a GNUism
Browse files Browse the repository at this point in the history
These tests just want a bit-for-bit identical copy; they do not need
even -H (there is no symbolic link involved) nor -p (there is no
funny permission or ownership issues involved).

Just use "cp -R" instead.

Signed-off-by: Ben Walton <bdwalton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Ben Walton authored and Junio C Hamano committed Oct 8, 2012
1 parent 9376c86 commit d4a7ffa
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion t/t5400-send-pack.sh
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ test_expect_success 'receive-pack runs auto-gc in remote repo' '
git commit -a -m "Second commit" &&
git repack
) &&
cp -a parent child &&
cp -R parent child &&
(
# Set the child to auto-pack if more than one pack exists
cd child &&
Expand Down
2 changes: 1 addition & 1 deletion t/t5550-http-fetch.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ test_expect_success 'setup repository' '
'

test_expect_success 'create http-accessible bare repository with loose objects' '
cp -a .git "$HTTPD_DOCUMENT_ROOT_PATH/repo.git" &&
cp -R .git "$HTTPD_DOCUMENT_ROOT_PATH/repo.git" &&
(cd "$HTTPD_DOCUMENT_ROOT_PATH/repo.git" &&
git config core.bare true &&
mkdir -p hooks &&
Expand Down
2 changes: 1 addition & 1 deletion t/t5800-remote-helpers.sh
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ test_expect_success 'pushing to local repo' '
# git-remote-testgit, but is too slow to leave in for general use.
: test_expect_success 'racily pushing to local repo' '
test_when_finished "rm -rf server2 localclone2" &&
cp -a server server2 &&
cp -R server server2 &&
git clone "testgit::${PWD}/server2" localclone2 &&
(cd localclone2 &&
echo content >>file &&
Expand Down

0 comments on commit d4a7ffa

Please sign in to comment.