Skip to content

Commit

Permalink
remove trailing LF in die() messages
Browse files Browse the repository at this point in the history
LF at the end of format strings given to die() is redundant because
die already adds one on its own.

Signed-off-by: Alexander Potashev <aspotashev@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Alexander Potashev authored and Junio C Hamano committed Jan 5, 2009
1 parent e89e2ed commit d753070
Show file tree
Hide file tree
Showing 16 changed files with 27 additions and 27 deletions.
2 changes: 1 addition & 1 deletion builtin-cat-file.c
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ static int cat_one_file(int opt, const char *exp_type, const char *obj_name)
break;

default:
die("git cat-file: unknown option: %s\n", exp_type);
die("git cat-file: unknown option: %s", exp_type);
}

if (!buf)
Expand Down
14 changes: 7 additions & 7 deletions builtin-clone.c
Original file line number Diff line number Diff line change
Expand Up @@ -192,15 +192,15 @@ static void copy_or_link_directory(struct strbuf *src, struct strbuf *dest)

dir = opendir(src->buf);
if (!dir)
die("failed to open %s\n", src->buf);
die("failed to open %s", src->buf);

if (mkdir(dest->buf, 0777)) {
if (errno != EEXIST)
die("failed to create directory %s\n", dest->buf);
die("failed to create directory %s", dest->buf);
else if (stat(dest->buf, &buf))
die("failed to stat %s\n", dest->buf);
die("failed to stat %s", dest->buf);
else if (!S_ISDIR(buf.st_mode))
die("%s exists and is not a directory\n", dest->buf);
die("%s exists and is not a directory", dest->buf);
}

strbuf_addch(src, '/');
Expand All @@ -224,16 +224,16 @@ static void copy_or_link_directory(struct strbuf *src, struct strbuf *dest)
}

if (unlink(dest->buf) && errno != ENOENT)
die("failed to unlink %s\n", dest->buf);
die("failed to unlink %s", dest->buf);
if (!option_no_hardlinks) {
if (!link(src->buf, dest->buf))
continue;
if (option_local)
die("failed to create link %s\n", dest->buf);
die("failed to create link %s", dest->buf);
option_no_hardlinks = 1;
}
if (copy_file(dest->buf, src->buf, 0666))
die("failed to copy file to %s\n", dest->buf);
die("failed to copy file to %s", dest->buf);
}
closedir(dir);
}
Expand Down
2 changes: 1 addition & 1 deletion builtin-fetch.c
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,7 @@ static void set_option(const char *name, const char *value)
{
int r = transport_set_option(transport, name, value);
if (r < 0)
die("Option \"%s\" value \"%s\" is not valid for %s\n",
die("Option \"%s\" value \"%s\" is not valid for %s",
name, value, transport->url);
if (r > 0)
warning("Option \"%s\" is ignored for %s\n",
Expand Down
2 changes: 1 addition & 1 deletion builtin-init-db.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ static void safe_create_dir(const char *dir, int share)
}
}
else if (share && adjust_shared_perm(dir))
die("Could not make %s writable by group\n", dir);
die("Could not make %s writable by group", dir);
}

static void copy_templates_1(char *path, int baselen,
Expand Down
2 changes: 1 addition & 1 deletion builtin-log.c
Original file line number Diff line number Diff line change
Expand Up @@ -815,7 +815,7 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
committer = git_committer_info(IDENT_ERROR_ON_NO_NAME);
endpos = strchr(committer, '>');
if (!endpos)
die("bogus committer info %s\n", committer);
die("bogus committer info %s", committer);
add_signoff = xmemdupz(committer, endpos - committer + 1);
}
else if (!strcmp(argv[i], "--attach")) {
Expand Down
2 changes: 1 addition & 1 deletion builtin-mailinfo.c
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ static void convert_to_utf8(struct strbuf *line, const char *charset)
return;
out = reencode_string(line->buf, metainfo_charset, charset);
if (!out)
die("cannot convert from %s to %s\n",
die("cannot convert from %s to %s",
charset, metainfo_charset);
strbuf_attach(line, out, strlen(out), strlen(out));
}
Expand Down
2 changes: 1 addition & 1 deletion builtin-merge-recursive.c
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ int cmd_merge_recursive(int argc, const char **argv, const char *prefix)
}

if (argc < 4)
die("Usage: %s <base>... -- <head> <remote> ...\n", argv[0]);
die("Usage: %s <base>... -- <head> <remote> ...", argv[0]);

for (i = 1; i < argc; ++i) {
if (!strcmp(argv[i], "--"))
Expand Down
2 changes: 1 addition & 1 deletion builtin-update-index.c
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ static int unresolve_one(const char *path)
static void read_head_pointers(void)
{
if (read_ref("HEAD", head_sha1))
die("No HEAD -- no initial commit yet?\n");
die("No HEAD -- no initial commit yet?");
if (read_ref("MERGE_HEAD", merge_head_sha1)) {
fprintf(stderr, "Not in the middle of a merge.\n");
exit(0);
Expand Down
2 changes: 1 addition & 1 deletion connect.c
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ static int git_tcp_connect_sock(char *host, int flags)
/* Not numeric */
struct servent *se = getservbyname(port,"tcp");
if ( !se )
die("Unknown port %s\n", port);
die("Unknown port %s", port);
nport = se->s_port;
}

Expand Down
2 changes: 1 addition & 1 deletion daemon.c
Original file line number Diff line number Diff line change
Expand Up @@ -716,7 +716,7 @@ static int socksetup(char *listen_addr, int listen_port, int **socklist_p)

gai = getaddrinfo(listen_addr, pbuf, &hints, &ai0);
if (gai)
die("getaddrinfo() failed: %s\n", gai_strerror(gai));
die("getaddrinfo() failed: %s", gai_strerror(gai));

for (ai = ai0; ai; ai = ai->ai_next) {
int sockfd;
Expand Down
2 changes: 1 addition & 1 deletion diff.c
Original file line number Diff line number Diff line change
Expand Up @@ -2039,7 +2039,7 @@ static void diff_fill_sha1_info(struct diff_filespec *one)
if (lstat(one->path, &st) < 0)
die("stat %s", one->path);
if (index_path(one->sha1, one->path, &st, 0))
die("cannot hash %s\n", one->path);
die("cannot hash %s", one->path);
}
}
else
Expand Down
2 changes: 1 addition & 1 deletion git.c
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ static int handle_alias(int *argcp, const char ***argv)
if (ret >= 0 && WIFEXITED(ret) &&
WEXITSTATUS(ret) != 127)
exit(WEXITSTATUS(ret));
die("Failed to run '%s' when expanding alias '%s'\n",
die("Failed to run '%s' when expanding alias '%s'",
alias_string + 1, alias_command);
}
count = split_cmdline(alias_string, &new_argv);
Expand Down
2 changes: 1 addition & 1 deletion grep.c
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ static int match_expr_eval(struct grep_opt *o,
h |= match_expr_eval(o, x->u.binary.right, bol, eol, ctx, 1);
break;
default:
die("Unexpected node type (internal error) %d\n", x->node);
die("Unexpected node type (internal error) %d", x->node);
}
if (collect_hits)
x->hit |= h;
Expand Down
6 changes: 3 additions & 3 deletions imap-send.c
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,9 @@ static int nfvasprintf(char **strp, const char *fmt, va_list ap)

len = vsnprintf(tmp, sizeof(tmp), fmt, ap);
if (len < 0)
die("Fatal: Out of memory\n");
die("Fatal: Out of memory");
if (len >= sizeof(tmp))
die("imap command overflow !\n");
die("imap command overflow!");
*strp = xmemdupz(tmp, len);
return len;
}
Expand Down Expand Up @@ -482,7 +482,7 @@ static int nfsnprintf(char *buf, int blen, const char *fmt, ...)

va_start(va, fmt);
if (blen <= 0 || (unsigned)(ret = vsnprintf(buf, blen, fmt, va)) >= (unsigned)blen)
die("Fatal: buffer too small. Please report a bug.\n");
die("Fatal: buffer too small. Please report a bug.");
va_end(va);
return ret;
}
Expand Down
2 changes: 1 addition & 1 deletion index-pack.c
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ static char *open_pack_file(char *pack_name)
} else
output_fd = open(pack_name, O_CREAT|O_EXCL|O_RDWR, 0600);
if (output_fd < 0)
die("unable to create %s: %s\n", pack_name, strerror(errno));
die("unable to create %s: %s", pack_name, strerror(errno));
pack_fd = output_fd;
} else {
input_fd = open(pack_name, O_RDONLY);
Expand Down
8 changes: 4 additions & 4 deletions pack-redundant.c
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ static void minimize(struct pack_list **min)
pll_free(perm_all);
}
if (perm_ok == NULL)
die("Internal error: No complete sets found!\n");
die("Internal error: No complete sets found!");

/* find the permutation with the smallest size */
perm = perm_ok;
Expand Down Expand Up @@ -573,14 +573,14 @@ static struct pack_list * add_pack_file(char *filename)
struct packed_git *p = packed_git;

if (strlen(filename) < 40)
die("Bad pack filename: %s\n", filename);
die("Bad pack filename: %s", filename);

while (p) {
if (strstr(p->pack_name, filename))
return add_pack(p);
p = p->next;
}
die("Filename %s not found in packed_git\n", filename);
die("Filename %s not found in packed_git", filename);
}

static void load_all(void)
Expand Down Expand Up @@ -636,7 +636,7 @@ int main(int argc, char **argv)
add_pack_file(*(argv + i++));

if (local_packs == NULL)
die("Zero packs found!\n");
die("Zero packs found!");

load_all_objects();

Expand Down

0 comments on commit d753070

Please sign in to comment.