Skip to content

Commit

Permalink
gitk: Avoid a crash in selectline if commitinfo($id) isn't set
Browse files Browse the repository at this point in the history
Occasionally I see a crash in selectline with commitinfo($id) not
set.  This makes sure it is set by calling getcommit $id if it isn't.

Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Paul Mackerras committed Mar 7, 2008
1 parent c9cfdc9 commit d76afb1
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion gitk
Original file line number Diff line number Diff line change
Expand Up @@ -1218,7 +1218,7 @@ proc chewcommits {} {
if {$viewcomplete($curview)} {
global commitidx varctok
global numcommits startmsecs
global mainheadid commitinfo nullid
global mainheadid nullid

if {[info exists pending_select]} {
set row [first_real_row]
Expand Down Expand Up @@ -5494,6 +5494,9 @@ proc selectline {l isnew} {
$ctext conf -state normal
clear_ctext
set linknum 0
if {![info exists commitinfo($id)]} {
getcommit $id
}
set info $commitinfo($id)
set date [formatdate [lindex $info 2]]
$ctext insert end "[mc "Author"]: [lindex $info 1] $date\n"
Expand Down

0 comments on commit d76afb1

Please sign in to comment.