Skip to content

Commit

Permalink
error_resolve_conflict: drop quotations around operation
Browse files Browse the repository at this point in the history
When you try to commit with unmerged entries, you get an
error like:

  $ git commit
  error: 'commit' is not possible because you have unmerged files.

The quotes around "commit" are clunky; the user doesn't care
that this message is a template with the command-name filled
in.  Saying:

  error: commit is not possible because you have unmerged files

is easier to read. As this code is called from other places,
we may also end up with:

  $ git merge
  error: merge is not possible because you have unmerged files

  $ git cherry-pick foo
  error: cherry-pick is not possible because you have unmerged files

  $ git revert foo
  error: revert is not possible because you have unmerged files

All of which look better without the quotes. This also
happens to match the behavior of "git pull", which generates
a similar message (but does not share code, as it is a shell
script).

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Jeff King authored and Junio C Hamano committed Jun 3, 2014
1 parent c057b24 commit d795216
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion advice.c
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ int git_default_advice_config(const char *var, const char *value)

int error_resolve_conflict(const char *me)
{
error("'%s' is not possible because you have unmerged files.", me);
error("%s is not possible because you have unmerged files.", me);
if (advice_resolve_conflict)
/*
* Message used both when 'git commit' fails and when
Expand Down

0 comments on commit d795216

Please sign in to comment.