Skip to content

Commit

Permalink
Merge branch 'nd/stop-setenv-work-tree'
Browse files Browse the repository at this point in the history
An earlier change in 2.5.x-era broke users' hooks and aliases by
exporting GIT_WORK_TREE to point at the root of the working tree,
interfering when they tried to use a different working tree without
setting GIT_WORK_TREE environment themselves.

* nd/stop-setenv-work-tree:
  Revert "setup: set env $GIT_WORK_TREE when work tree is set, like $GIT_DIR"
  • Loading branch information
Junio C Hamano committed Jan 12, 2016
2 parents 7548842 + df1e6ea commit d82d093
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 0 additions & 2 deletions environment.c
Original file line number Diff line number Diff line change
Expand Up @@ -235,8 +235,6 @@ void set_git_work_tree(const char *new_work_tree)
}
git_work_tree_initialized = 1;
work_tree = xstrdup(real_path(new_work_tree));
if (setenv(GIT_WORK_TREE_ENVIRONMENT, work_tree, 1))
die("could not set GIT_WORK_TREE to '%s'", work_tree);
}

const char *get_git_work_tree(void)
Expand Down
2 changes: 1 addition & 1 deletion t/t0002-gitfile.sh
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ test_expect_success 'check rev-list' '
test "$SHA" = "$(git rev-list HEAD)"
'

test_expect_success 'setup_git_dir twice in subdir' '
test_expect_failure 'setup_git_dir twice in subdir' '
git init sgd &&
(
cd sgd &&
Expand Down

0 comments on commit d82d093

Please sign in to comment.