Skip to content

Commit

Permalink
cvsserver update: comment about how we shouldn't remove a user-modifi…
Browse files Browse the repository at this point in the history
…ed file

Instead of a comment, we should really add test cases and actually fix it.

Signed-off-by: Matthew Ogilvie <mmogilvi_git@miniinfo.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Matthew Ogilvie authored and Junio C Hamano committed Oct 16, 2012
1 parent 196e48f commit d8574ff
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions git-cvsserver.perl
Original file line number Diff line number Diff line change
Expand Up @@ -1144,6 +1144,10 @@ sub req_update

if ( $meta->{filehash} eq "deleted" )
{
# TODO: If it has been modified in the sandbox, error out
# with the appropriate message, rather than deleting a modified
# file.

my ( $filepart, $dirpart ) = filenamesplit($filename,1);

$log->info("Removing '$filename' from working copy (no longer in the repo)");
Expand Down

0 comments on commit d8574ff

Please sign in to comment.