Skip to content

Commit

Permalink
rev-list: honor --quiet option
Browse files Browse the repository at this point in the history
Nick Andrew noticed that rev-list lets --quiet option to be parsed by
underlying diff_options parser but did not pick up the result.  This
resulted in --quiet option to become effectively a no-op.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Junio C Hamano committed Jul 18, 2008
1 parent 6c69207 commit d85fe38
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions builtin-rev-list.c
Original file line number Diff line number Diff line change
Expand Up @@ -597,6 +597,7 @@ int cmd_rev_list(int argc, const char **argv, const char *prefix)
revs.commit_format = CMIT_FMT_UNSPECIFIED;
argc = setup_revisions(argc, argv, &revs, NULL);

quiet = DIFF_OPT_TST(&revs.diffopt, QUIET);
for (i = 1 ; i < argc; i++) {
const char *arg = argv[i];

Expand Down Expand Up @@ -628,10 +629,6 @@ int cmd_rev_list(int argc, const char **argv, const char *prefix)
read_revisions_from_stdin(&revs);
continue;
}
if (!strcmp(arg, "--quiet")) {
quiet = 1;
continue;
}
usage(rev_list_usage);

}
Expand Down

0 comments on commit d85fe38

Please sign in to comment.