Skip to content

Commit

Permalink
rerere: fix for merge.conflictstyle
Browse files Browse the repository at this point in the history
If we use a different conflict style `git rerere forget` is not able
to find the matching conflict SHA-1 because the diff generated is
actually different from what `git merge` generated, due to the
XDL_MERGE_* option differences among the codepaths.

The fix is to call git_xmerge_config() so that git_xmerge_style is set
properly and the diffs match.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Reviewed-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Felipe Contreras authored and Junio C Hamano committed Apr 30, 2014
1 parent 7bbc4e8 commit de3d8bb
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions builtin/rerere.c
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ int cmd_rerere(int argc, const char **argv, const char *prefix)

argc = parse_options(argc, argv, prefix, options, rerere_usage, 0);

git_config(git_xmerge_config, NULL);

if (autoupdate == 1)
flags = RERERE_AUTOUPDATE;
if (autoupdate == 0)
Expand Down

0 comments on commit de3d8bb

Please sign in to comment.