Skip to content

Commit

Permalink
fsck.c:fsck_ident(): ident points at a const string
Browse files Browse the repository at this point in the history
Since fsck_ident doesn't change the content of **ident, the type of
ident could be const char **.

This change is required to rewrite fsck_commit() to use skip_prefix().

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Helped-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Yuxuan Shui authored and Junio C Hamano committed Mar 13, 2014
1 parent 5f95c9f commit de42180
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions fsck.c
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ static int fsck_tree(struct tree *item, int strict, fsck_error error_func)
return retval;
}

static int fsck_ident(char **ident, struct object *obj, fsck_error error_func)
static int fsck_ident(const char **ident, struct object *obj, fsck_error error_func)
{
if (**ident == '<')
return error_func(obj, FSCK_ERROR, "invalid author/committer line - missing space before email");
Expand Down Expand Up @@ -281,7 +281,7 @@ static int fsck_ident(char **ident, struct object *obj, fsck_error error_func)

static int fsck_commit(struct commit *commit, fsck_error error_func)
{
char *buffer = commit->buffer;
const char *buffer = commit->buffer;
unsigned char tree_sha1[20], sha1[20];
struct commit_graft *graft;
int parents = 0;
Expand Down

0 comments on commit de42180

Please sign in to comment.