Skip to content

Commit

Permalink
streaming_write_entry(): support files with holes
Browse files Browse the repository at this point in the history
One typical use of a large binary file is to hold a sparse on-disk hash
table with a lot of holes. Help preserving the holes with lseek().

Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Junio C Hamano committed May 21, 2011
1 parent b0d9c69 commit de6182d
Showing 1 changed file with 19 additions and 2 deletions.
21 changes: 19 additions & 2 deletions entry.c
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ static int streaming_write_entry(struct cache_entry *ce, char *path,
enum object_type type;
unsigned long sz;
int result = -1;
ssize_t kept = 0;
int fd = -1;

st = open_istream(ce->sha1, &type, &sz);
Expand All @@ -136,18 +137,34 @@ static int streaming_write_entry(struct cache_entry *ce, char *path,
goto close_and_exit;

for (;;) {
char buf[10240];
ssize_t wrote;
char buf[1024 * 16];
ssize_t wrote, holeto;
ssize_t readlen = read_istream(st, buf, sizeof(buf));

if (!readlen)
break;
if (sizeof(buf) == readlen) {
for (holeto = 0; holeto < readlen; holeto++)
if (buf[holeto])
break;
if (readlen == holeto) {
kept += holeto;
continue;
}
}

if (kept && lseek(fd, kept, SEEK_CUR) == (off_t) -1)
goto close_and_exit;
else
kept = 0;
wrote = write_in_full(fd, buf, readlen);

if (wrote != readlen)
goto close_and_exit;
}
if (kept && (lseek(fd, kept - 1, SEEK_CUR) == (off_t) -1 ||
write(fd, "", 1) != 1))
goto close_and_exit;
*fstat_done = fstat_output(fd, state, statbuf);

close_and_exit:
Expand Down

0 comments on commit de6182d

Please sign in to comment.