Skip to content

Commit

Permalink
t4049: refocus tests
Browse files Browse the repository at this point in the history
The primary thing Linus's patch wanted to change was to make sure
that 0-line change appears for a mode-only change.  Update the
first test to chmod a file that we can see in the output (limited
by --stat-count) to demonstrate it.  Also make sure to use test_chmod
and compare the index and the tree, so that we can run this test
even on a filesystem without permission bits.

Later two tests are about fixes to separate issues that were
introduced and/or uncovered by Linus's patch as a side effect, but
the issues are not related to mode-only changes.  Remove chmod from
the tests.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Junio C Hamano committed Nov 29, 2012
1 parent 20c8cde commit de90959
Showing 1 changed file with 9 additions and 11 deletions.
20 changes: 9 additions & 11 deletions t/t4049-diff-stat-count.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,32 +13,31 @@ test_expect_success 'setup' '
git commit -m initial
'

test_expect_success 'limit output to 2 (simple)' '
test_expect_success 'mode-only change show as a 0-line change' '
git reset --hard &&
chmod +x c d &&
test_chmod +x b d &&
echo a >a &&
echo b >b &&
echo c >c &&
cat >expect <<-\EOF
a | 1 +
b | 1 +
b | 0
...
4 files changed, 2 insertions(+)
EOF
git diff --stat --stat-count=2 >actual &&
git diff --stat --stat-count=2 HEAD >actual &&
test_i18ncmp expect actual
'

test_expect_success 'binary changes do not count in lines' '
git reset --hard &&
chmod +x c d &&
echo a >a &&
echo b >b &&
echo c >c &&
cat "$TEST_DIRECTORY"/test-binary-1.png >d &&
cat >expect <<-\EOF
a | 1 +
b | 1 +
c | 1 +
...
4 files changed, 2 insertions(+)
3 files changed, 2 insertions(+)
EOF
git diff --stat --stat-count=2 >actual &&
test_i18ncmp expect actual
Expand All @@ -56,12 +55,11 @@ test_expect_success 'exclude unmerged entries from total file count' '
done |
git update-index --index-info &&
echo d >d &&
chmod +x c d &&
cat >expect <<-\EOF
a | 1 +
b | 1 +
...
4 files changed, 3 insertions(+)
3 files changed, 3 insertions(+)
EOF
git diff --stat --stat-count=2 >actual &&
test_i18ncmp expect actual
Expand Down

0 comments on commit de90959

Please sign in to comment.