Skip to content

Commit

Permalink
Merge branch 'maint'
Browse files Browse the repository at this point in the history
* maint:
  Typo fix: replacing it's -> its
  t: make PIPE a standard test prerequisite
  archive: clarify explanation of --worktree-attributes
  t/README: --immediate skips cleanup commands for failed tests
  • Loading branch information
Junio C Hamano committed Apr 12, 2013
2 parents 7ece7ee + 3a51467 commit e2af9e3
Show file tree
Hide file tree
Showing 7 changed files with 20 additions and 21 deletions.
4 changes: 3 additions & 1 deletion Documentation/git-archive.txt
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ OPTIONS
Write the archive to <file> instead of stdout.

--worktree-attributes::
Look for attributes in .gitattributes in working directory too.
Look for attributes in .gitattributes files in the working tree
as well (see <<ATTRIBUTES>>).

<extra>::
This can be any options that the archiver backend understands.
Expand Down Expand Up @@ -120,6 +121,7 @@ tar.<format>.remote::
user-defined formats, but true for the "tar.gz" and "tgz"
formats.

[[ATTRIBUTES]]
ATTRIBUTES
----------

Expand Down
2 changes: 1 addition & 1 deletion INSTALL
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ Issues of note:
- "openssl" library is used by git-imap-send to use IMAP over SSL.
If you don't need it, use NO_OPENSSL.

By default, git uses OpenSSL for SHA1 but it will use it's own
By default, git uses OpenSSL for SHA1 but it will use its own
library (inspired by Mozilla's) with either NO_OPENSSL or
BLK_SHA1. Also included is a version optimized for PowerPC
(PPC_SHA1).
Expand Down
4 changes: 2 additions & 2 deletions perl/private-Error.pm
Original file line number Diff line number Diff line change
Expand Up @@ -630,7 +630,7 @@ Only one finally block may be specified per try block
=head2 CONSTRUCTORS
The C<Error> object is implemented as a HASH. This HASH is initialized
with the arguments that are passed to it's constructor. The elements
with the arguments that are passed to its constructor. The elements
that are used by, or are retrievable by the C<Error> class are listed
below, other classes may add to these.
Expand Down Expand Up @@ -763,7 +763,7 @@ to the constructor.
=item Error::Simple
This class can be used to hold simple error strings and values. It's
This class can be used to hold simple error strings and values. Its
constructor takes two arguments. The first is a text value, the second
is a numeric value. These values are what will be returned by the
overload methods.
Expand Down
10 changes: 9 additions & 1 deletion t/README
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,10 @@ appropriately before running "make".

--immediate::
This causes the test to immediately exit upon the first
failed test.
failed test. Cleanup commands requested with
test_when_finished are not executed if the test failed,
in order to keep the state for inspection by the tester
to diagnose the bug.

--long-tests::
This causes additional long-running tests to be run (where
Expand Down Expand Up @@ -619,6 +622,11 @@ use these, and "test_set_prereq" for how to define your own.
The process retains the same pid across exec(2). See fb9a2bea for
details.

- PIPE

The filesystem we're on supports creation of FIFOs (named pipes)
via mkfifo(1).

- SYMLINKS

The filesystem we're on supports symbolic links. E.g. a FAT
Expand Down
8 changes: 0 additions & 8 deletions t/t9010-svn-fe.sh
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,6 @@ text_no_props () {

>empty

test_expect_success 'setup: have pipes?' '
rm -f frob &&
if mkfifo frob
then
test_set_prereq PIPE
fi
'

test_expect_success PIPE 'empty dump' '
reinit_git &&
echo "SVN-fs-dump-format-version: 2" >input &&
Expand Down
8 changes: 0 additions & 8 deletions t/t9300-fast-import.sh
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,6 @@ echo "$@"'

>empty

test_expect_success 'setup: have pipes?' '
rm -f frob &&
if mkfifo frob
then
test_set_prereq PIPE
fi
'

###
### series A
###
Expand Down
5 changes: 5 additions & 0 deletions t/test-lib.sh
Original file line number Diff line number Diff line change
Expand Up @@ -735,6 +735,11 @@ test_i18ngrep () {
fi
}

test_lazy_prereq PIPE '
# test whether the filesystem supports FIFOs
rm -f testfifo && mkfifo testfifo
'

test_lazy_prereq SYMLINKS '
# test whether the filesystem supports symbolic links
ln -s x y && test -h y
Expand Down

0 comments on commit e2af9e3

Please sign in to comment.