Skip to content

Commit

Permalink
Bisect visualize: use "for-each-ref" to list all good refs.
Browse files Browse the repository at this point in the history
In bisect_visualize, "cd $GIT_DIR/refs && echo bisect/good-*" was
still used instead of "git for-each-ref". This patch fix it.

We now pass "refs/bisect/bad" and "--not refs/bisect/good-<rev>"
instead of "bisect/bad" and "--not bisect/good-<rev>" to gitk,
but it seems to work.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Christian Couder authored and Junio C Hamano committed Nov 17, 2007
1 parent 0bee49c commit e3f062b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions git-bisect.sh
Original file line number Diff line number Diff line change
Expand Up @@ -324,8 +324,8 @@ bisect_next() {

bisect_visualize() {
bisect_next_check fail
not=`cd "$GIT_DIR/refs" && echo bisect/good-*`
eval gitk bisect/bad --not $not -- $(cat "$GIT_DIR/BISECT_NAMES")
not=$(git for-each-ref --format='%(refname)' "refs/bisect/good-*")
eval gitk refs/bisect/bad --not $not -- $(cat "$GIT_DIR/BISECT_NAMES")
}

bisect_reset() {
Expand Down

0 comments on commit e3f062b

Please sign in to comment.