Skip to content

Commit

Permalink
send-email: avoid open "-|" list form for Perl 5.6
Browse files Browse the repository at this point in the history
Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Junio C Hamano committed Feb 20, 2006
1 parent fedd273 commit e415907
Showing 1 changed file with 21 additions and 16 deletions.
37 changes: 21 additions & 16 deletions git-send-email.perl
Original file line number Diff line number Diff line change
Expand Up @@ -59,24 +59,29 @@

# Now, let's fill any that aren't set in with defaults:

open(GITVAR,"-|","git-var","-l")
or die "Failed to open pipe from git-var: $!";

my ($author,$committer);
while(<GITVAR>) {
chomp;
my ($var,$data) = split /=/,$_,2;
my @fields = split /\s+/, $data;

my $ident = join(" ", @fields[0...(@fields-3)]);
sub gitvar {
my ($var) = @_;
my $fh;
my $pid = open($fh, '-|');
die "$!" unless defined $pid;
if (!$pid) {
exec('git-var', $var) or die "$!";
}
my ($val) = <$fh>;
close $fh or die "$!";
chomp($val);
return $val;
}

if ($var eq 'GIT_AUTHOR_IDENT') {
$author = $ident;
} elsif ($var eq 'GIT_COMMITTER_IDENT') {
$committer = $ident;
}
sub gitvar_ident {
my ($name) = @_;
my $val = gitvar($name);
my @field = split(/\s+/, $val);
return join(' ', @field[0...(@field-3)]);
}
close(GITVAR);

my ($author) = gitvar_ident('GIT_AUTHOR_IDENT');
my ($committer) = gitvar_ident('GIT_COMMITTER_IDENT');

my $prompting = 0;
if (!defined $from) {
Expand Down

0 comments on commit e415907

Please sign in to comment.