Skip to content

Commit

Permalink
Merge branch 'kd/pull-rebase-autostash'
Browse files Browse the repository at this point in the history
"git pull --rebase" has been taught to pay attention to
rebase.autostash configuration.

* kd/pull-rebase-autostash:
  pull: allow dirty tree when rebase.autostash enabled
  • Loading branch information
Junio C Hamano committed Aug 17, 2015
2 parents 130be8e + 53c76dc commit e69b408
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
6 changes: 5 additions & 1 deletion builtin/pull.c
Original file line number Diff line number Diff line change
Expand Up @@ -823,10 +823,14 @@ int cmd_pull(int argc, const char **argv, const char *prefix)
hashclr(orig_head);

if (opt_rebase) {
int autostash = 0;

if (is_null_sha1(orig_head) && !is_cache_unborn())
die(_("Updating an unborn branch with changes added to the index."));

die_on_unclean_work_tree(prefix);
git_config_get_bool("rebase.autostash", &autostash);
if (!autostash)
die_on_unclean_work_tree(prefix);

if (get_rebase_fork_point(rebase_fork_point, repo, *refspecs))
hashclr(rebase_fork_point);
Expand Down
11 changes: 11 additions & 0 deletions t/t5520-pull.sh
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,17 @@ test_expect_success '--rebase fails with multiple branches' '
test modified = "$(git show HEAD:file)"
'

test_expect_success 'pull --rebase succeeds with dirty working directory and rebase.autostash set' '
test_config rebase.autostash true &&
git reset --hard before-rebase &&
echo dirty >new_file &&
git add new_file &&
git pull --rebase . copy &&
test_cmp_rev HEAD^ copy &&
test "$(cat new_file)" = dirty &&
test "$(cat file)" = "modified again"
'

test_expect_success 'pull.rebase' '
git reset --hard before-rebase &&
test_config pull.rebase true &&
Expand Down

0 comments on commit e69b408

Please sign in to comment.