copy.c::copy_fd() - do not leak file descriptor on error return.

Signed-off-by: Junio C Hamano <junkio@cox.net>
git-mirror · Nov 5, 2005 · e6c64fc · e6c64fc
1 parent 28ffb89
commit e6c64fc
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/copy.c b/copy.c
@@ -10,10 +10,13 @@ int copy_fd(int ifd, int ofd)
 		if (!len)
 			break;
 		if (len < 0) {
+			int read_error;
 			if (errno == EAGAIN)
 				continue;
+			read_error = errno;
+			close(ifd);
 			return error("copy-fd: read returned %s",
-				     strerror(errno));
+				     strerror(read_error));
 		}
 		while (1) {
 			int written = write(ofd, buf, len);