Skip to content

Commit

Permalink
gitk: Fix bug where editing an existing view would cause an infinite …
Browse files Browse the repository at this point in the history
…loop

This fixes a bug where changing the commit range or file list for an
existing view and then clicking OK would cause gitk to go into an
infinite loop.  The problem was that newviewok was invoking reloadcommits
via "run reloadcommits", but reloadcommits wasn't explicitly returning
0, and whatever it was returning was causing dorunq to run it over
and over again.  This fixes it by making reloadcommits return 0.

Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Paul Mackerras committed Jan 15, 2008
1 parent 46308ea commit e7297a1
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions gitk
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@ proc reloadcommits {} {
catch {unset targetid}
setcanvscroll
getcommits
return 0
}

# This makes a string representation of a positive integer which
Expand Down

0 comments on commit e7297a1

Please sign in to comment.