Skip to content

Commit

Permalink
Fix "git log --merge --left-right"
Browse files Browse the repository at this point in the history
The command did not reject the combination of these options, but
did not show left/right markers.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Junio C Hamano committed Feb 27, 2008
1 parent 81fa145 commit e82447b
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions revision.c
Original file line number Diff line number Diff line change
Expand Up @@ -749,14 +749,9 @@ static void prepare_show_merge(struct rev_info *revs)
add_pending_object(revs, &head->object, "HEAD");
add_pending_object(revs, &other->object, "MERGE_HEAD");
bases = get_merge_bases(head, other, 1);
while (bases) {
struct commit *it = bases->item;
struct commit_list *n = bases->next;
free(bases);
bases = n;
it->object.flags |= UNINTERESTING;
add_pending_object(revs, &it->object, "(merge-base)");
}
add_pending_commit_list(revs, bases, UNINTERESTING);
free_commit_list(bases);
head->object.flags |= SYMMETRIC_LEFT;

if (!active_nr)
read_cache();
Expand All @@ -775,6 +770,7 @@ static void prepare_show_merge(struct rev_info *revs)
i++;
}
revs->prune_data = prune;
revs->limited = 1;
}

int handle_revision_arg(const char *arg, struct rev_info *revs,
Expand Down

0 comments on commit e82447b

Please sign in to comment.