Skip to content

Commit

Permalink
show <tag>: reuse pp_user_info() instead of duplicating code
Browse files Browse the repository at this point in the history
We used to extract the tagger information "by hand" in "git show <tag>",
but the function pp_user_info() already does that.  Even better:
it respects the commit_format and date_format specified by the user.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Johannes Schindelin authored and Junio C Hamano committed Jan 5, 2009
1 parent df63fbb commit ea718e6
Showing 1 changed file with 6 additions and 15 deletions.
21 changes: 6 additions & 15 deletions builtin-log.c
Original file line number Diff line number Diff line change
Expand Up @@ -249,22 +249,13 @@ int cmd_whatchanged(int argc, const char **argv, const char *prefix)

static void show_tagger(char *buf, int len, struct rev_info *rev)
{
char *email_end, *p;
unsigned long date;
int tz;
struct strbuf out = STRBUF_INIT;

email_end = memchr(buf, '>', len);
if (!email_end)
return;
p = ++email_end;
while (isspace(*p))
p++;
date = strtoul(p, &p, 10);
while (isspace(*p))
p++;
tz = (int)strtol(p, NULL, 10);
printf("Tagger: %.*s\nDate: %s\n", (int)(email_end - buf), buf,
show_date(date, tz, rev->date_mode));
pp_user_info("Tagger", rev->commit_format, &out, buf, rev->date_mode,
git_log_output_encoding ?
git_log_output_encoding: git_commit_encoding);
printf("%s\n", out.buf);
strbuf_release(&out);
}

static int show_object(const unsigned char *sha1, int show_tag_object,
Expand Down

0 comments on commit ea718e6

Please sign in to comment.