Skip to content

Commit

Permalink
bash: Support internal revlist options better.
Browse files Browse the repository at this point in the history
format-patch/log/whatchanged all take --not and --all as options
to the internal revlist process.  So these should be supported
as possible completions.

gitk takes anything rev-list/log/whatchanged takes, so we should
use complete_revlist to handle its options.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Shawn O. Pearce authored and Junio C Hamano committed Feb 4, 2007
1 parent b339177 commit ec80489
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion contrib/completion/git-completion.bash
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,7 @@ _git_format_patch ()
--signoff
--in-reply-to=
--full-index --binary
--not --all
"
return
;;
Expand Down Expand Up @@ -532,6 +533,7 @@ _git_log ()
--author= --committer= --grep=
--all-match
--pretty= --name-status --name-only
--not --all
"
return
;;
Expand Down Expand Up @@ -898,7 +900,7 @@ _gitk ()
return
;;
esac
__gitcomp "$(__git_refs)"
__git_complete_revlist
}

complete -o default -o nospace -F _git git
Expand Down

0 comments on commit ec80489

Please sign in to comment.