-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
write-tree: properly detect failure to write tree objects
Tomasz Fortuna reported that "git commit" does not error out properly when it cannot write tree objects out. "git write-tree" shares the same issue, as the failure to notice the error is deep in the logic to write tree objects out recursively. Signed-off-by: Junio C Hamano <gitster@pobox.com>
- Loading branch information
Junio C Hamano
committed
Apr 23, 2008
1 parent
4f7ec79
commit edae5f0
Showing
2 changed files
with
72 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
#!/bin/sh | ||
|
||
test_description='detect unwritable repository and fail correctly' | ||
|
||
. ./test-lib.sh | ||
|
||
test_expect_success setup ' | ||
>file && | ||
git add file && | ||
git commit -m initial && | ||
echo >file && | ||
git add file | ||
' | ||
|
||
test_expect_success 'write-tree should notice unwritable repository' ' | ||
( | ||
chmod a-w .git/objects | ||
test_must_fail git write-tree | ||
) | ||
status=$? | ||
chmod 775 .git/objects | ||
(exit $status) | ||
' | ||
|
||
test_expect_success 'commit should notice unwritable repository' ' | ||
( | ||
chmod a-w .git/objects | ||
test_must_fail git commit -m second | ||
) | ||
status=$? | ||
chmod 775 .git/objects | ||
(exit $status) | ||
' | ||
|
||
test_expect_success 'update-index should notice unwritable repository' ' | ||
( | ||
echo a >file && | ||
chmod a-w .git/objects | ||
test_must_fail git update-index file | ||
) | ||
status=$? | ||
chmod 775 .git/objects | ||
(exit $status) | ||
' | ||
|
||
test_expect_success 'add should notice unwritable repository' ' | ||
( | ||
echo b >file && | ||
chmod a-w .git/objects | ||
test_must_fail git add file | ||
) | ||
status=$? | ||
chmod 775 .git/objects | ||
(exit $status) | ||
' | ||
|
||
test_done |