Skip to content

Commit

Permalink
Teach git-pull to pass -X<option> to git-merge
Browse files Browse the repository at this point in the history
This needs the usual sq then eval trick to allow IFS characters
in the option.

Signed-off-by: Avery Pennarun <apenwarr@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Avery Pennarun authored and Junio C Hamano committed Jan 18, 2010
1 parent 8cc5b29 commit ee2c795
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 2 deletions.
17 changes: 15 additions & 2 deletions git-pull.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ test -z "$(git ls-files -u)" ||

strategy_args= diffstat= no_commit= squash= no_ff= ff_only=
log_arg= verbosity=
merge_args=
curr_branch=$(git symbolic-ref -q HEAD)
curr_branch_short=$(echo "$curr_branch" | sed "s|refs/heads/||")
rebase=$(git config --bool branch.$curr_branch_short.rebase)
Expand Down Expand Up @@ -62,6 +63,18 @@ do
esac
strategy_args="${strategy_args}-s $strategy "
;;
-X*)
case "$#,$1" in
1,-X)
usage ;;
*,-X)
xx="-X $2"
shift ;;
*,*)
xx="$1" ;;
esac
merge_args="$merge_args$xx "
;;
-r|--r|--re|--reb|--reba|--rebas|--rebase)
rebase=true
;;
Expand Down Expand Up @@ -216,7 +229,7 @@ fi

merge_name=$(git fmt-merge-msg $log_arg <"$GIT_DIR/FETCH_HEAD") || exit
test true = "$rebase" &&
exec git-rebase $diffstat $strategy_args --onto $merge_head \
exec git-rebase $diffstat $strategy_args $merge_args --onto $merge_head \
${oldremoteref:-$merge_head}
exec git-merge $diffstat $no_commit $squash $no_ff $ff_only $log_arg $strategy_args \
exec git-merge $diffstat $no_commit $squash $no_ff $ff_only $log_arg $strategy_args $merge_args \
"$merge_name" HEAD $merge_head $verbosity
8 changes: 8 additions & 0 deletions t/t6037-merge-ours-theirs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,12 @@ test_expect_success 'recursive favouring ours' '
! grep 1 file
'

test_expect_success 'pull with -X' '
git reset --hard master && git pull -s recursive -Xours . side &&
git reset --hard master && git pull -s recursive -X ours . side &&
git reset --hard master && git pull -s recursive -Xtheirs . side &&
git reset --hard master && git pull -s recursive -X theirs . side &&
git reset --hard master && ! git pull -s recursive -X bork . side
'

test_done

0 comments on commit ee2c795

Please sign in to comment.