Skip to content

Commit

Permalink
GIT 1.5.5.6
Browse files Browse the repository at this point in the history
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Junio C Hamano committed Dec 17, 2008
2 parents 006f31d + 34b146c commit f23ffbe
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 37 deletions.
10 changes: 10 additions & 0 deletions Documentation/RelNotes-1.5.4.7.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
GIT v1.5.4.7 Release Notes
==========================

Fixes since 1.5.4.7
-------------------

* Removed support for an obsolete gitweb request URI, whose
implementation ran "git diff" Porcelain, instead of using plumbing,
which would have run an external diff command specified in the
repository configuration as the gitweb user.
10 changes: 10 additions & 0 deletions Documentation/RelNotes-1.5.5.6.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
GIT v1.5.5.6 Release Notes
==========================

Fixes since 1.5.5.5
-------------------

* Removed support for an obsolete gitweb request URI, whose
implementation ran "git diff" Porcelain, instead of using plumbing,
which would have run an external diff command specified in the
repository configuration as the gitweb user.
2 changes: 1 addition & 1 deletion RelNotes
38 changes: 2 additions & 36 deletions gitweb/gitweb.perl
Original file line number Diff line number Diff line change
Expand Up @@ -4877,43 +4877,9 @@ sub git_blobdiff {
or die_error(undef, "Open git-diff-tree failed");
}

# old/legacy style URI
if (!%diffinfo && # if new style URI failed
defined $hash && defined $hash_parent) {
# fake git-diff-tree raw output
$diffinfo{'from_mode'} = $diffinfo{'to_mode'} = "blob";
$diffinfo{'from_id'} = $hash_parent;
$diffinfo{'to_id'} = $hash;
if (defined $file_name) {
if (defined $file_parent) {
$diffinfo{'status'} = '2';
$diffinfo{'from_file'} = $file_parent;
$diffinfo{'to_file'} = $file_name;
} else { # assume not renamed
$diffinfo{'status'} = '1';
$diffinfo{'from_file'} = $file_name;
$diffinfo{'to_file'} = $file_name;
}
} else { # no filename given
$diffinfo{'status'} = '2';
$diffinfo{'from_file'} = $hash_parent;
$diffinfo{'to_file'} = $hash;
}

# non-textual hash id's can be cached
if ($hash =~ m/^[0-9a-fA-F]{40}$/ &&
$hash_parent =~ m/^[0-9a-fA-F]{40}$/) {
$expires = '+1d';
}

# open patch output
open $fd, "-|", git_cmd(), "diff", @diff_opts,
'-p', ($format eq 'html' ? "--full-index" : ()),
$hash_parent, $hash, "--"
or die_error(undef, "Open git-diff failed");
} else {
# old/legacy style URI -- not generated anymore since 1.4.3.
if (!%diffinfo) {
die_error('404 Not Found', "Missing one of the blob diff parameters")
unless %diffinfo;
}

# header
Expand Down

0 comments on commit f23ffbe

Please sign in to comment.