Skip to content

Commit

Permalink
test suite: remove useless TERM cruft in "t7005-editor.sh"
Browse files Browse the repository at this point in the history
In commit 15387e3 (Test suite: reset TERM to its previous value after
testing., 2007-10-26), I added a workaround to reset TERM to its previous
value before the "test_done" at the end of "t7005-editor.sh" because
otherwise "test_done" would have printed the test result with a bad TERM
env variable (this resulted in output with no color on konsole).

But since commit c2116a1 (test-lib: fix TERM to dumb for test
repeatability, 2008-03-06), colored output is printed in a subshell with
TERM reset to its original value so the earlier workaround is not needed
anymore.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Christian Couder authored and Junio C Hamano committed Apr 7, 2008
1 parent d9e3b70 commit f2b3e3c
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions t/t7005-editor.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ test_description='GIT_EDITOR, core.editor, and stuff'

. ./test-lib.sh

OLD_TERM="$TERM"

for i in GIT_EDITOR core_editor EDITOR VISUAL vi
do
cat >e-$i.sh <<-EOF
Expand Down Expand Up @@ -116,6 +114,4 @@ test_expect_success 'core.editor with a space' '
'

TERM="$OLD_TERM"

test_done

0 comments on commit f2b3e3c

Please sign in to comment.