Skip to content

Commit

Permalink
Enable HEAD@{...} and make it independent from the current branch
Browse files Browse the repository at this point in the history
Signed-off-by: Nicolas Pitre <nico@cam.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
  • Loading branch information
Nicolas Pitre authored and Junio C Hamano committed Feb 4, 2007
1 parent d77ee72 commit f2eba66
Showing 1 changed file with 36 additions and 26 deletions.
62 changes: 36 additions & 26 deletions sha1_name.c
Original file line number Diff line number Diff line change
Expand Up @@ -235,22 +235,23 @@ static int ambiguous_path(const char *path, int len)
return slash;
}

static const char *ref_fmt[] = {
"%.*s",
"refs/%.*s",
"refs/tags/%.*s",
"refs/heads/%.*s",
"refs/remotes/%.*s",
"refs/remotes/%.*s/HEAD",
NULL
};

int dwim_ref(const char *str, int len, unsigned char *sha1, char **ref)
{
static const char *fmt[] = {
"%.*s",
"refs/%.*s",
"refs/tags/%.*s",
"refs/heads/%.*s",
"refs/remotes/%.*s",
"refs/remotes/%.*s/HEAD",
NULL
};
const char **p, *r;
int refs_found = 0;

*ref = NULL;
for (p = fmt; *p; p++) {
for (p = ref_fmt; *p; p++) {
unsigned char sha1_from_ref[20];
unsigned char *this_result;

Expand All @@ -266,6 +267,28 @@ int dwim_ref(const char *str, int len, unsigned char *sha1, char **ref)
return refs_found;
}

static int dwim_log(const char *str, int len, unsigned char *sha1, char **log)
{
const char **p;
int logs_found = 0;

*log = NULL;
for (p = ref_fmt; *p; p++) {
struct stat st;
char *path = mkpath(*p, len, str);
if (!stat(git_path("logs/%s", path), &st) &&
S_ISREG(st.st_mode)) {
if (!logs_found++) {
*log = xstrdup(path);
resolve_ref(path, sha1, 0, NULL);
}
if (!warn_ambiguous_refs)
break;
}
}
return logs_found;
}

static int get_sha1_basic(const char *str, int len, unsigned char *sha1)
{
static const char *warning = "warning: refname '%.*s' is ambiguous.\n";
Expand Down Expand Up @@ -295,7 +318,9 @@ static int get_sha1_basic(const char *str, int len, unsigned char *sha1)
if (!len && reflog_len) {
/* allow "@{...}" to mean the current branch reflog */
refs_found = dwim_ref("HEAD", 4, sha1, &real_ref);
} else
} else if (reflog_len)
refs_found = dwim_log(str, len, sha1, &real_ref);
else
refs_found = dwim_ref(str, len, sha1, &real_ref);

if (!refs_found)
Expand All @@ -310,21 +335,6 @@ static int get_sha1_basic(const char *str, int len, unsigned char *sha1)
unsigned long co_time;
int co_tz, co_cnt;

/*
* We'll have an independent reflog for "HEAD" eventually
* which won't be a synonym for the current branch reflog.
* In the mean time prevent people from getting used to
* such a synonym until the work is completed.
*/
if (len && !strncmp("HEAD", str, len) &&
!strncmp(real_ref, "refs/", 5)) {
error("reflog for HEAD has not been implemented yet\n"
"Maybe you could try %s%s instead, "
"or just %s for current branch..",
strchr(real_ref+5, '/')+1, str+len, str+len);
exit(-1);
}

/* Is it asking for N-th entry, or approxidate? */
for (i = nth = 0; 0 <= nth && i < reflog_len; i++) {
char ch = str[at+2+i];
Expand Down

0 comments on commit f2eba66

Please sign in to comment.